feat: add hasPoint function to GraphPoints #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nithos @amostafa-uncharted @nkronenfeld if any of you three have some time to review this very small PR, this change will be useful for a perf optimization in Recourse. |
|
Review requires someone with write access to Grafer - I think that's just @Nithos at the moment. I can't even assign myself as a reviewer. That being said, it's hard to see any actual harm caused by this PR. |
Nithos
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a utility function to check if GraphPoints has a point with a particular ID. This is useful for tracking the existence of particular points to know whether we need to call
setPointByIDoraddPoints.