Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hasPoint function to GraphPoints #198

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat: add hasPoint function to GraphPoints #198

merged 1 commit into from
Jun 5, 2024

Conversation

ccarmichael-uncharted
Copy link
Collaborator

This PR adds a utility function to check if GraphPoints has a point with a particular ID. This is useful for tracking the existence of particular points to know whether we need to call setPointByID or addPoints.

@ccarmichael-uncharted
Copy link
Collaborator Author

@Nithos @amostafa-uncharted @nkronenfeld if any of you three have some time to review this very small PR, this change will be useful for a perf optimization in Recourse.

@nkronenfeld
Copy link

Review requires someone with write access to Grafer - I think that's just @Nithos at the moment. I can't even assign myself as a reviewer.

That being said, it's hard to see any actual harm caused by this PR.

@Nithos Nithos merged commit d3ad3d1 into main Jun 5, 2024
6 checks passed
@Nithos Nithos deleted the add-has-point branch June 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants