Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for edge picking width #99

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Add option for edge picking width #99

merged 1 commit into from
Aug 21, 2023

Conversation

mj3cheun
Copy link
Contributor

No description provided.

@@ -53,3 +53,4 @@ An object containing configuration options for the edges.
| nearDepth | number | Takes a range between 0 to 1. Defaults to 0. Controls camera near depth. |
| farDepth | number | Takes a range between 0 to 1. Defaults to 1. Controls camera far depth. |
| lineWidth | number | Sets the line width of the edges in the layer |
| pickingWidth | number | Sets the width of the edge picking area in the layer where applicable, as a multiplier of the `lineWidth`. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

src/graph/edges/Edges.ts Show resolved Hide resolved
Copy link
Collaborator

@Nithos Nithos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the default value in the MD doc. Otherwise good start.
As discussed we can try making this more dynamic by default in the near future.

@mj3cheun mj3cheun merged commit f4d858a into main Aug 21, 2023
8 checks passed
@mj3cheun mj3cheun deleted the picking-width-option branch August 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants