Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #86 #87

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixes #86 #87

wants to merge 7 commits into from

Conversation

dixonte
Copy link

@dixonte dixonte commented Sep 14, 2022

I'm not 100% happy with this as I am sure I left a lot of stuff untouched that needed updating, but it works for my specific case.

  • Replaces spaces with underscores in member names in C#
  • Uses underscore instead of @ for reserved words in C#, so it can be used in private members
  • Adds 'Context' to list of reserved words, to prevent hiding necessary inherited member
  • Adds an option to write the Edmx as an embedded file instead of a string literal

@dixonte
Copy link
Author

dixonte commented Sep 15, 2022

  • Undid the replacement of @ with underscore for conflicts with language keywords
  • Added a different check for conflicts with important inherited members, like Context. Underscore gets added to the end of these members

@dazinator
Copy link

Any news on when this might be merged?

@dazinator
Copy link

dazinator commented Jan 13, 2023

@dixonte I've been using your fork, also targeting Dynamics 365 FO, I have been seeing the following error, not sure if it is related to your changes or not, wondered if you had seen it? I ticked the option to generate client with property change tracking, and "async base"

image

Have created issue details here: #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants