Addresses Issue #1465 : Added possibility to manage accounts in the UI. #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suratdas I haven't gotten round to looking at the code yet. But just based on the screenshots I would like to suggest you change 'Manage My Account' to 'Change Password'. Would it be possible to remove the 'Manage Other Users' option completely unless the user is logged in as admin? |
|
@fhoeben Thanks for the feedback. I have committed all the changes you requested. |
fhoeben
requested changes
Jan 13, 2024
|
Thanks for the review comments. I have updated based on your feedback. The new UI looks like this now.
|
fhoeben
requested changes
Jan 14, 2024
FitNesseRoot/FitNesse/UserGuide/AdministeringFitNesse/PasswordFile/content.txt
Outdated
Show resolved
Hide resolved
FitNesseRoot/FitNesse/UserGuide/AdministeringFitNesse/PasswordFile/content.txt
Outdated
Show resolved
Hide resolved
FitNesseRoot/FitNesse/UserGuide/AdministeringFitNesse/PasswordFile/content.txt
Outdated
Show resolved
Hide resolved
FitNesseRoot/FitNesse/UserGuide/AdministeringFitNesse/PasswordFile/content.txt
Outdated
Show resolved
Hide resolved
FitNesseRoot/FitNesse/UserGuide/AdministeringFitNesse/PasswordFile/content.txt
Outdated
Show resolved
Hide resolved
…File/content.txt Co-authored-by: Fried Hoeben <github@hsac.nl>
…File/content.txt Co-authored-by: Fried Hoeben <github@hsac.nl>
…File/content.txt Co-authored-by: Fried Hoeben <github@hsac.nl>
…File/content.txt Co-authored-by: Fried Hoeben <github@hsac.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to change password, create user, delete user all from UI. The logged in user can see the username in the UI. The log out part is still not in this pull request. That will take some time and will come in a future PR. Below are the screenshots.