Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variable values to ScopeVariablesResponder #1472

Conversation

AlexNetcare
Copy link
Contributor

This will add the values for the variables to the table. So instead of going to a variables location you can see the value directly in the table.

@fhoeben
Copy link
Collaborator

fhoeben commented Jan 12, 2024

Can you add a description of this feature to FitNesseRoot/FitNesse/ReleaseNotes/content.txt

Furthermore I just noticed that the responder is not documented at all in the user guide. That is a shame as it is a really useful tool. Could you maybe add a short description somewhere in the user guide pages (I think FitNesseRoot/FitNesse/UserGuide/WritingAcceptanceTests/VariableScope/content.txt might be a good location)?
Doesn't have to be fancy, but it would be good if people could see they can get an overview (and how).

@AlexNetcare
Copy link
Contributor Author

There is a small information in the User Guide for the Responder under FitNesseRoot/FitNesse/UserGuide/AdministeringFitNesse/RestfulServices/content.txt. But updating the user guide for the VariableScope still seems good to me.

Additionally on the Variable Scope page, I added the information that only variables with !define are shown on the page. Variables like PAGE_PATH or PAGE_NAME are not shown. I am not sure if that was intended or not but I didn't want to change too much.

Copy link
Collaborator

@fhoeben fhoeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor rephrase of some of the documentation, but great otherwise

Co-authored-by: Fried Hoeben <github@hsac.nl>
@fhoeben fhoeben merged commit bd43869 into unclebob:master Jan 16, 2024
1 check passed
@AlexNetcare AlexNetcare deleted the feature/add-variable-values-to-ScopeVariablesResponder branch April 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants