Fix RerunLastFailures problem. Appear the perfix only one time #1512
Conversation
|
@Eqerem-Hena Thanks a lot for your PR! I believe you are generating unique names for each re-rerun by adding a counter at the end, correct? Like I stated in the issue just having one rerun per page/suite seems fine. So this PR could be much simpler: just don't add the |
|
It also seems like some of the existing tests failed, can that be related to your change or did we let something else slip through and break that already? |
I think it is a better idea to add the counter at the end, as in this way it will be more understandable to the user which rerun page is. |
I don't think so. It's probably from a previous commit. |
|
The original submitter of the issue indicated:
So they prefer not to have an additional file for each rerun. |
I did a new commit. Please, check it out! |
| @@ -295,7 +295,12 @@ protected String getRerunPageName() { | |||
| PageCrawler pageCrawler = page.getPageCrawler(); | |||
| WikiPagePath fullPath = pageCrawler.getFullPath(); | |||
| String fullPathName = PathParser.render(fullPath); | |||
| return "RerunLastFailures_"+fullPathName.replace(".","-"); | |||
| if (fullPathName.startsWith("RerunLastFailures_")) { | |||
| String newFullPathName = fullPathName.replace(".", "-"); | |||
There was a problem hiding this comment.
I think it makes more sense to to the replace on line 297 to remove the duplicated code from both branches
|
Could you also update the release notes? |
|
Cleaned up the tests in #1519 |
Fix the #1342 issue.