Fixed header overlapping content #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhoeben
reviewed
Jul 1, 2024
| @@ -61,5 +61,18 @@ | |||
| </footer> | |||
| #end | |||
|
|
|||
| <script> | |||
| function adjustPadding() { | |||
| var navHeight = document.querySelector('nav').offsetHeight; | |||
There was a problem hiding this comment.
Just to be sure I suggest you check whether document.querySelector('nav') gives a result before trying to use it.
There was a problem hiding this comment.
Added a simple check. If a nav Element does not exist then there won't be an exception in the Console now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to figure out Bootstrap, I found a Solution for the header overlapping the content when the header size changes. This might be a fix for #1514 unless I misinterpreted the Issue.
I was hoping to find a Bootstrap Solution but I either didn't find it or there is no other more elegant one.