Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce testing time #1518

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Reduce testing time #1518

merged 2 commits into from
Jul 7, 2024

Conversation

six42
Copy link
Contributor

@six42 six42 commented Jun 30, 2024

Reduce testing time

  • by reducing timeouts to the minimum,
    
  • deleting test case SlimConnectionTimeout which is a duplicate of C_TimeoutAsNoServerAtGivenSocket
    
  • skipping performance test in the standard build as it is a long running test and no assertion on the performance
    

by reducing timeouts to the minimum,
deleting test case SlimConnectionTimeout which is a duplicate of C_TimeoutAsNoServerAtGivenSocket
skipping performance test in the stadard build
@six42
Copy link
Contributor Author

six42 commented Jun 30, 2024

Comparing this build in GitHub with the previous one the improvement is as expected: 10-20 sec = 10-20% reduced time

Old version 5 May

https://github.com/unclebob/fitnesse/actions/runs/8960309727/job/24606661122
Total time 3m 30s
Build with Gradle 3m 10s
Acceptance Tests
327 Tests, 0 Failures 64.340 seconds.

this PR on Jun 30

https://github.com/unclebob/fitnesse/actions/runs/9733320118/job/26860095078
Total time in 3m 9s
Build with Gradle 2m 51s
Acceptance Tests
326 Tests, 0 Failures 56.499 seconds.

Copy link
Collaborator

@fhoeben fhoeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. I added some minor questions

@fhoeben fhoeben merged commit 19ac942 into unclebob:master Jul 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants