Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1735] add reason-phrase handler and make response-code obey… #1419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-1735] add reason-phrase handler and make response-code obey… #1419

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Dec 9, 2022

… doc contract of one-by-one execution
Issue: https://issues.redhat.com/browse/UNDERTOW-1735

@baranowb
Copy link
Contributor Author

I have no idea why this is failing, it does work locally.

@bdw429s
Copy link
Contributor

bdw429s commented Dec 23, 2022

@baranowb @fl4via Please see my questions concerning the implementation of my ticket in the comments here:
https://issues.redhat.com/browse/UNDERTOW-1735

@fl4via fl4via added under verification Currently being verified (running tests, reviewing) before posting a review to contributor new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) labels Jan 13, 2023
@fl4via
Copy link
Member

fl4via commented Jan 13, 2023

@bdw429s thanks for the feedback! I'm studying what is the preferable approach. I might take a little longer to respond as I'm away on PTO, but worst case scenario is you will hear back from me when I'm back, on Jan 26th. This applies to all your requests and pending messages, including the ones in the google user groups.

@bdw429s
Copy link
Contributor

bdw429s commented Jan 25, 2023

@baranowb Thanks, the response() handler looks sweet!

@baranowb baranowb added the waiting peer review PRs that edit core classes might require an extra review label Mar 27, 2024
@baranowb
Copy link
Contributor Author

AsyncListenerExceptionTest

@baranowb
Copy link
Contributor Author

SameSiteCookieHandlerTestCase AsyncListenerExceptionTest

@baranowb baranowb requested a review from fl4via November 29, 2024 14:03
baranowb
baranowb commented Nov 29, 2024
View reviewed changes
core/src/main/java/io/undertow/UndertowMessages.java
@@ -655,4 +655,7 @@ public interface UndertowMessages {
@Message(id = 210, value = "Buffer content underflow for exchange '%s', buffer '%s'")
IOException bufferUnderflow(HttpServerExchange exchange, ByteBuffer buf);

@Message(id = 211, value = "Exchange '%s' already has body or is blocking.")
IOException exhangeBlockingOrBlocking(HttpServerExchange e);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also name is wrong. I will update on monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@jasondlee jasondlee Awaiting requested review from jasondlee

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baranowb @bdw429s @fl4via @ropalka