Multiplayer FaceCam #624
Merged
Multiplayer FaceCam #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ideo/chunk sending.
…e else has a silver FaceCam.
But everyone but not the server sends it to themselfs too. This should be fixed.
…all clients, but not to themselfs.
…d Network-Test-Stuff into the FaceCam folder.
… Simple fix in FaceCam.cs.
… the size of the FaceCam.
…ped with a little extra space.
Simplified code. Fixed error related to y position. My cat walked over the keyboard this somehow disabled the red square and implemented zoom onto the face instead of jumping right to it.
falko17
reviewed
Jul 18, 2023
Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
Improved error message format.
Shortened long lines. Accepted performance improvement suggested by Visual Studio.
# Conflicts: # Assets/SEE/Net/Network.cs
We want to abstract from the kind of interaction (keyboard or trigger on a VR controller). Moreover, we want to have one single location in the code where all key bindings are defined so that we can check whether there are any conflicts. In fact, a conflict with KeyCode.O existed. Switching the facecam's position on the player is now bound to KeyCode.F3.
FaceCam will instantiated also for a client (may be a temporary change).
koschke
requested changes
Jul 29, 2023
There was a problem hiding this comment.
I fixed a few more issues. In particular, I replaced the reference to Input and KeyCode by a more abstract SEEInput call. Never use Input and KeyCode. There was a keybinding conflict in key O. The facecam's position can now be switched by F3.
Otherwise, the code looks good. However, in my test with two different computers, the face mask worked only on the machine acting as the host. On the client machine, it doesn't. I noticed and marked the responsible source code in file PlayerSpawner.cs, which spawns the FaceCam prefab only on the server. Removing the condition didn't work. There were NetCode errors raised then.
This needs further investigation.
In some not yet investigated case a node exists already in the object manager. We need to look into that. I filed issue #630 for that.
# Conflicts: # .gitattributes
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…-FaceCam # Conflicts: # Assets/SEE/Tools/FaceCam/FaceCam.cs
The check has no type information. In this particular case, the argument is a Texture, not a GameObject and the use of Object.Destroy would have been fine. To deal with similar situations, I generalized Destroyer.Destroy from Component to Object. Removed some redundancy. Fixed bug: Added missing parameter recurseIntoChildren in recursive call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a live transmission of the face, in front or above the avatar.
Users with a webcam can enable this feature.
Resolves and closes #560.
Features
Controls
Performance
The host receives all the videos that contain the cropped face and forwards them only to the clients that have not yet received the video.
It tries to use the most direct functions of Unity's "Netcode for GameObjects" as well as the functions from the code used in the OpenCV plugin examples.
Hopefully a more performant implementation of the functions provided by Unity on the OpenCV plugins will also improve the performance of this feature (like the conversion between JPG and 'texture2D' becoming more efficient). Then it may also be possible to switch to unreliable RPCs, as well as possibly choose a different container for network transmission than JPG. It is also possible no conversion from 'texture2D' might be necessary.
Self-adjusting resolution, compression, bitrate and FPS would also be a great addition.