Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

563 incremental layout #636

Merged
merged 133 commits into from
Sep 20, 2023
Merged

563 incremental layout #636

merged 133 commits into from
Sep 20, 2023

Conversation

SchrammJonas
Copy link
Collaborator

Implements a new node layout for the evolution setting.

m4xxed and others added 30 commits March 23, 2023 13:54
Copy link
Collaborator

@falko17 falko17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last comments with respect to the most recent changes, but almost all of these have suggestions that can be automatically applied.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few bad patterns I found which you should check.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@falko17 falko17 force-pushed the 563-incremental-layout branch 2 times, most recently from a469950 to 5fac91f Compare September 15, 2023 20:24
@falko17
Copy link
Collaborator

falko17 commented Sep 15, 2023

Note: Due to me rebasing this branch, I am listed as the committer instead of @SchrammJonas in some of these commits on GitHub (the correct author is displayed using e.g. git log locally, and the correct author is also listed when clicking on a commit in GitHub, which displays both committer and author separately).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few bad patterns I found which you should check.

Assets/SEE/Game/City/NodeLayoutAttributes.cs Outdated Show resolved Hide resolved
…tespace

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@koschke koschke merged commit 89307f3 into master Sep 20, 2023
10 checks passed
@koschke koschke deleted the 563-incremental-layout branch September 20, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants