642 face cam #646
Merged
642 face cam #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was set in the prefab, but we changed its visibility from public to private, in which case it is not serialized by default.
The FaceCam prefab will become a child of a player prefab, which is also a NetworkObject. Nested NetworkObjects are not allowed.
The FaceCam prefab will become a child of a player prefab, which is also a NetworkObject. Nested NetworkObjects are not allowed. That is why we just instantiate, but not spawn it.
It is used in the context of players.
Is does not need to be instantiated here. We want it to be instantiated for all players, not only those for the player on the server.
Previously, it was only deactivated, but it still didn't work.
when OnNetworkSpawn(). OnNetworkSpawn() can be called before Start().
instead of adding them as an instantiated child. This way we can make changes to the FaceCam only once for all players.
It caused trouble even though it was deactivated.
FaceCamOnOffToggle() is using this field, too.
LocalPlayer is now in a class of its own. It didn't belong here.
Added debugging output.
This may be the case on artificial nodes, such as the artificial roots on reflexion cities.
koschke
commented
Oct 5, 2023
koschke
commented
Oct 5, 2023
koschke
commented
Oct 5, 2023
Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
falko17
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is workings towards showing the video of all desktop player on all clients. Currently that is not the case as reported in issue #642. The problem is not yet fixed but in the course of starting to work on this issue here in this branch I fixed a null-pointer dereference during start-up of a player's avatar, reported by @falko17.
The changes made in this pull request fixes the problem and should be merged into the master. The branch will continue to exist for the additional work required for issue #642.