Tree View: Color, animations, click-to-find #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to specify operations that shall be stopped when this operation is started.
They have also been renamed such that the `Set` prefix is removed, since this is a common pattern for chainable method calls like these.
This refactors GraphElementOperator to a major extent: It splits it off into a non-generic class, which handles all non-color operations, and one generic part which handles the rest. This makes it possible for callers to access GraphElementOperator without needing to know of what type the underlying element is. Additionally, this allows the following previously node-exclusive operations to be used on edges as well: * Blink() * Highlight()
Previously, these were only available on GraphElements – now they were made available for GameObjects too.
This also fixes a bug in which scrolling no longer worked.
This way, if we decide to change how we would like to retrieve operators in the future, we can simply change the extension method rather than having to change every instance in the code.
Previously, the component was stored in an out variable. The new approach has the advantage that calls can be chained on the return value – returning the component in an out variable mainly makes sense when the method itself has a different return value, which was not the case here.
falko17
force-pushed
the
expand-tree-view
branch
2 times, most recently
from
1fb69e6
to
2133f08
Compare
koschke
reviewed
Oct 17, 2023
koschke
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the TreeView, which was introduced in #641, and refactors some operator-related code.
TreeView changes
Operator and related changes
ConflictingOperationshas been added toAbstractOperation. If an operation conflicts with another, it will be killed before the other operation is started. This is a bidirectional relationship.NodeOperatoroperation.EdgeOperator.GraphElementOperatorsuperclass, which can be used to operate on graph elements in general.gameObject.NodeOperator()can be used.node.Operator()can be used.MustGetComponentnow returns the component directly rather than using anoutparameter, since it had avoidreturn type before.IsNode(),IsEdge()) is now determined by the presence of a corresponding tag, rather than by trying to get a reference component.GameObjectFlasherclass has been removed. InInteractableObject,GraphElementOperator.Blinkis used instead.