Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

479 onboarding Lysander #651

Closed
wants to merge 3 commits into from
Closed

479 onboarding Lysander #651

wants to merge 3 commits into from

Conversation

lilSander
Copy link
Collaborator

No description provided.

@lilSander lilSander linked an issue Oct 19, 2023 that may be closed by this pull request
Onboarding of new SEE members #479
Open
4 tasks
@lilSander lilSander changed the title alles auf einmal 479 onboarding Lysander Oct 19, 2023
koschke
koschke requested changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine. There are only a few minor code issues.

Assets/SEE/Controls/Actions/MarkAction.cs Outdated Show resolved Hide resolved
Assets/SEE/Controls/Actions/MarkAction.cs Outdated Show resolved Hide resolved
Assets/SEE/Controls/Actions/MarkAction.cs Show resolved Hide resolved
Assets/SEE/Controls/Actions/MarkAction.cs Outdated Show resolved Hide resolved
Assets/SEE/Controls/Actions/MarkAction.cs Outdated Show resolved Hide resolved
Assets/SEE/Game/SceneManipulation/GameNodeMarker.cs Outdated Show resolved Hide resolved
Assets/SEE/Game/SceneManipulation/GameNodeMarker.cs Outdated Show resolved Hide resolved
Assets/SEE/Game/SceneManipulation/GameNodeMarker.cs Outdated Show resolved Hide resolved
Assets/SEE/Game/SceneManipulation/GameNodeMarker.cs Show resolved Hide resolved
Assets/SEE/Net/Actions/MarkNetAction.cs Outdated Show resolved Hide resolved
@koschke
Copy link
Collaborator

koschke commented Oct 28, 2023

PR was only for the onboarding task. The onboarding task will not be merged.

@koschke koschke closed this Oct 28, 2023
@koschke koschke deleted the 479-onboarding-Lysander branch October 28, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koschke koschke koschke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onboarding of new SEE members
2 participants
@lilSander @koschke