497 onboarding timdinh #653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koschke
requested changes
Oct 22, 2023
| using SEE.Game.SceneManipulation; | ||
|
|
||
| namespace SEE.Controls.Actions { | ||
| public class MarkAction : AbstractPlayerAction |
There was a problem hiding this comment.
Documentation is missing.
|
|
||
| /// <summary> | ||
| /// If the user clicks with the mouse hitting a game object representing a graph node, | ||
| /// will be marked. A sphere will appear above the marked node. |
There was a problem hiding this comment.
Missing it in front of will be marked.
| Vector3 position = parent.transform.position; | ||
| Vector3 scale = parent.transform.lossyScale; | ||
| // create or delete the sphere | ||
| addedSphere = GameNodeMarker.CreateOrDeleteSphere(parent, scale); |
There was a problem hiding this comment.
Why passing scale as a parameter? Position and scale can be retrieved by GameNodeMarker.CreateOrDeleteSphere.
| } | ||
| } | ||
| } | ||
|
|
| public override void Redo() | ||
| { | ||
| base.Redo(); | ||
| addedSphere = GameNodeAdder.AddChild(memento.Parent, worldSpacePosition: memento.Position, worldSpaceScale: memento.Scale, nodeID: memento.NodeID); |
There was a problem hiding this comment.
This is wrong. You must use GameNodeMarker.CreateOrDeleteSphere.
| using System.Collections.Generic; | ||
| using UnityEngine; | ||
|
|
||
| namespace SEE.Game.Scenemanipulation |
There was a problem hiding this comment.
Scenemanipulation must be SceneManipulation. Note that C# is case-sensitive.
| /// </summary> | ||
| /// <param name="parent">selected node</param> | ||
| /// <param name="scale">scale of the node</param> | ||
| /// <returns></returns> |
| { | ||
| GameObject sphere = null; | ||
| //Search for sphere | ||
| foreach(Transform child in parent.transform) |
There was a problem hiding this comment.
You could replace the loop by parent.transform.Find("Sphere").
| { | ||
| GameObject sphere = null; | ||
| //Search for sphere | ||
| foreach(Transform child in parent.transform) |
| } | ||
| } | ||
| //Delete sphere if one existed | ||
| if(sphere != null) |
|
PR was only for the onboarding task. The onboarding task will not be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking and unmarking nodes has been implemented