Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView: Search and smaller improvements #656

Merged
merged 11 commits into from
Oct 29, 2023
Merged

TreeView: Search and smaller improvements #656

merged 11 commits into from
Oct 29, 2023

Conversation

falko17
Copy link
Collaborator

@falko17 falko17 commented Oct 27, 2023

This implements a search field for the TreeView. Left-clicking on a result will reveal it in the full hierarchy of the TreeView, while a right-click highlights it within the scene.
The search algorithm was also refactored into a general GraphSearch class, which may be used to search for graph elements outside the TreeView class as well.
Additionally, the old SearchMenu has been fully removed, as its functionality is now present within the TreeView.

@falko17 falko17 added the enhancement New feature or request label Oct 27, 2023
@falko17 falko17 added this to the Qt World Summit milestone Oct 27, 2023
@falko17 falko17 requested a review from koschke October 27, 2023 23:59
@falko17 falko17 self-assigned this Oct 27, 2023
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I have only minor remarks you should look at.

Assets/SEE/DataModel/DG/GraphSearch.cs Outdated Show resolved Hide resolved
Assets/SEE/DataModel/DG/GraphSearch.cs Show resolved Hide resolved
Assets/SEE/DataModel/DG/GraphSearch.cs Show resolved Hide resolved
Assets/SEE/UI/Window/TreeWindow/DesktopTreeWindow.cs Outdated Show resolved Hide resolved
Assets/SEE/Utils/ColorExtensions.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read to merge.

@koschke koschke merged commit aaa31fc into master Oct 29, 2023
10 checks passed
@koschke
Copy link
Collaborator

koschke commented Oct 29, 2023

I suppose the branch should continue to exist, so I won't delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants