Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unity xr 544 draft Pull Request #671

Closed
wants to merge 139 commits into from
Closed

Unity xr 544 draft Pull Request #671

wants to merge 139 commits into from

Conversation

WilliamGoesGit
Copy link
Collaborator

VR isn't working yet.

@koschke
#544 AutoHand is part of LFS.
6c90331
@koschke
#544 Imported Auto Hand version 3.1.3.
c640238 
Purchased license.
@koschke
#544 Additional TextMesh Pro assets as a consequence of imported Auto…
716c7f5 
… Hand.
@koschke
#544 Adaptive force was enabled by AutoHand.
8eaf073
@koschke
#544 Fixed undefined layer and missing materials.
6d94d0b 
Layer 22 was used in the prefabs shipped by AutoHand, but does not exist.
We are now using the Default layer instead.
Some materials did not exist. I added an existing one.
@koschke
#544 Quality was defined.
f8982fd
@koschke
#544 AutoHand settings are used for normal quality.
a39ec54
@koschke
#544 More layer 22 fixes.
89f026b
@koschke
#544 FinalIK integration example of AutoHand.
661b4f2 
Extracted from "Assets/AutoHand/Packages (Setup)/FinalIK.unitypackage".
@koschke
#544 Added necessary assembly definitions and references.
4501631
@koschke
#544 Removed obsolete prefabs.
b48dab7
@koschke
#544 Removed a component without code (non-existing script).
2897b34
@koschke
#544 Imported Assets Cleaner PRO | Clean References version 1.26.
9468278
@koschke
#544 no longer used
f64eb96
@koschke
#544 Removed obsolete assets.
066642a
@koschke
#544 Removed obsolete SteamVR resources assets.
f526690
@koschke
#544 Removed SteamVR.
9e038f8
@koschke
#544 Removed FinalIK's example for SteamVR.
09257f5
@koschke
#544 SteamVR is no longer used directly.
9d0c6fd
@koschke
#544 Removed obsolete Whiteboard.
0a467d3 
It was never used and depended upon SteamVR.
@koschke
#544 We are now using Newtonsoft.Json instead of Valve.Newtonsoft.Json.
6a85e05 
The latter comes with SteamVR, but SteamVR is no longer used directly.
@koschke
#544 Removed unused imports.
3cb7005
@koschke
#544 Added an animation for state Idle.
008fc7c 
For some unknown reason, it was lost.
@koschke
#544 We are using our own variant of ColorWithAlpha.
65055bd 
No longer the one provided by SteamVR. Both are identical anyhow.
@koschke
#544 Removed unused imports.
7d9ddfb
@koschke
#544 Disabled our dependencies on SteamVR.
449f4af 
We need to revive those functions using new Unity's XR kit.
@koschke
#544 We are using our own WithAlpha function.
797f814
@koschke
#544 Added Valve Index Controller Profile.
0abe89c
@koschke
#544 Disabled OpenVR Loader (SteamVR).
b95901c
@koschke
#544 Copied and adjusted the FullBodyPlayer from AutoHand's FinalIK e…
098d6e6 
…xample.

This will be the basis for our VR avatars.
@koschke
Copy link
Collaborator

koschke commented Nov 16, 2023

@Yvo02 Please make sure that your commit messages are informative. Your last ones aren't ("update").

@koschke koschke added the Improvement Improvement of existing features label Nov 16, 2023
@koschke koschke added this to the Qt World Summit milestone Nov 16, 2023
@koschke koschke linked an issue Nov 16, 2023 that may be closed by this pull request
Use new Unity XR subsystem, get rid of SteamVR #544
Open
6 tasks
@falko17
Copy link
Collaborator

falko17 commented Nov 17, 2023

Please note additionally that, as described in the CI, you will have to rebase the branch to get rid of the non-LFS assets outside the Plugins/ folder from the commit history. During this rebase step, you could also reword the commit messages to be in German.

WilliamGoesGit and others added 21 commits November 17, 2023 14:45
@WilliamGoesGit
#544 Updated Finger Positions
1ad79ce
@WilliamGoesGit
#544 Added Follow Hand Offset.
37b3eaa
@WilliamGoesGit
#524 Modified version of the XRRig.prefab -still flawed - for easier …
49cdb22 
…reloading
@WilliamGoesGit
#544 Further adjustments to the prefab -> offsets still need to be set.
35f530c
@WilliamGoesGit
#544 -Update
9b2fdab
@WilliamGoesGit
#544 Small Changes in the prefab and rework of fingers
2de49d1
@WilliamGoesGit
#544 Right Hand Position Fix
c530935
@WilliamGoesGit
#544 Updated Finger Positions
14b4d29
@WilliamGoesGit
#544 Added Follow Hand Offset.
fc3d6f7
@WilliamGoesGit
Merge remote-tracking branch 'origin/unity-xr-544' into unity-xr-544
67a640e
@Yvo02
Hopefully fixed FullBodyPlayer.prefab #544
590fc51
@Yvo02
#544 removed male2 from XRRig
6131b67
@Yvo02
Added missing files from AutoHand examples #544
c378f8e
@WilliamGoesGit
#544 Fixed Finger Offset
b5664f4
@WilliamGoesGit
#544 Added SetupAutoHandVRIK
50c1a52
@WilliamGoesGit
#544 Added a comment
f14a1bf
@Yvo02
#544 fixed autohand assembly definitons
8635258
@Yvo02
#544 Deleted AssetCleaner. Moved to plugins folder.
d25460f
@Yvo02
#544 Fixed AvatarAdapter setupAutoHandVRIK
b650ccd
@Yvo02
#544 added test script to fullbodyplayer
fe7bd3a
@Yvo02
#544 Added tracker offset strings to XRCameraRigManager
4bcbdae
@koschke
Copy link
Collaborator

koschke commented May 10, 2024

This PR has not received any changes for a very long time. I am deleting it to clean up, but the branch will continue to exist in case something were needed. Maybe we start from scratch when migrating to the CC4 avatars.

@koschke koschke closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improvement Improvement of existing features
Projects
None yet
Milestone
Qt World Summit
Development

Successfully merging this pull request may close these issues.

Use new Unity XR subsystem, get rid of SteamVR
5 participants
@WilliamGoesGit @koschke @falko17 @Yvo02 @GniLudio