Livekit GUI improvement #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pit2710
force-pushed
the
livekit-gui-improvement
branch
2 times, most recently
from
546e544
to
54286ae
Compare
Refactored `LivekitVideoManager.cs`: - Changed `NetworkBehaviour` to `MonoBehaviour` - Removed `RepublishVideo` method - Updated camera methods: - Last selected camera saved in `PlayerPrefs` - Unpublished video if camera changed - Camera activates when video is published - Camera deactivates when video is unpublished - Added `StatusPanel` for publish status Modified `SEENewWorld`: - Removed `LivekitVideoManager` object Updated `SettingsMenu` prefab: - Centered exit button - Added `VideochatStatusPanel` as first child: - Added `RawImage` for status image (assigned to `LivekitVideoManager` script) - Added `Text` for status display (assigned to `LivekitVideoManager` script) - Added `VideochatPanel` as child: - Added `Dropdown` (assigned to `LivekitVideoManager` script)
pit2710
force-pushed
the
livekit-gui-improvement
branch
from
54286ae
to
63aa4e2
Compare
- Removed redundant check for available devices in camera selection - Added functionality to save selected camera to PlayerPrefs in OpenSelectedCamera method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the video chat GUI. The cameras can now be selected in the SettingsMenu. A status panel of the shared video has been added at the bottom left of the screen.
Refactored
LivekitVideoManager.cs:NetworkBehaviourtoMonoBehaviourRepublishVideomethodPlayerPrefsStatusPanelfor publish statusModified
SEENewWorld:LivekitVideoManagerobjectUpdated
SettingsMenuprefab:VideochatStatusPanelas first child:RawImagefor status image (assigned toLivekitVideoManagerscript)Textfor status display (assigned toLivekitVideoManagerscript)VideochatPanelas child:Dropdown(assigned toLivekitVideoManagerscript)