Edge direction visualization via shader #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a dedicated EdgeShader that handles color gradient. A vertex deformation effect can be configured and toggled that allows for a direction visualization. The effect depends on a correct UV mapping and uses the direction as present in our custom 3D edge meshes. The smoothness of the effect relies on several configurable parameters and the vertex density of the original mesh.
falko17
requested changes
Oct 18, 2024
Implement changes suggested by reviewer @falko17.
|
Thank you for the review. I have applied the suggested changes. |
Implement changes suggested by reviewer @falko17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a dedicated EdgeShader that handles color gradient. A vertex deformation effect can be configured and toggled that allows for a direction visualization. The effect depends on a correct UV mapping and uses the direction as present in our custom 3D edge meshes. The smoothness of the effect relies on several configurable parameters and the vertex density of the original mesh.
The shader is applied to our 3D edge meshes generated in SEESpline. The old direction visualization is replaced.
This MR fixes #789.