Start adding concrete format functions #5688
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5269 (comment)
This approach we discussed doesn't completely work because it doesn't accomplish the type inference I wanted to see, because I need to accept a
Date<A: AsCalendar>
, not an actual concreteDate<C>
. This voids most of the benefit of having concrete functions because then you can't.into()
or.parse()
into the type being formatted.Thought: if I made
.format_date
take a concreteDate<C>
(disallowing the use ofRef
), I could keep.format
as-is, and then these concrete format functions become nice-to-haves that can be added on later. I think this is most aligned with the design @Manishearth had preferred anyway.Would be nice to land this in 2.0-Alpha, but it's fine if it changes in 2.0-Beta.
CC @Manishearth @robertbastian