Sort scx based on script codes rather than aliases. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
approved these changes
Apr 14, 2023
markusicu
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating the UCD currently flips
# Script_Extensions=Arab Nkooand# Script_Extensions=Arab Rohg, as was noted by @markusicu in #416 (comment). This is very annoying in the new world where we want to have many draft PRs in flight for a long time, requiring frequent regeneration of the UCD.This is happening because #398 ordered these inconsistently with the order produced by
MakeUnicodeFiles. That was intentional: the pull request description readsThis was already the case, but the sorting was alphabetical by alias, rather than script code, and
Rohg=Hanifi_Rohingya<Nko=Nkoo. The alternative to this PR would be for @roozbehp to change the logic in https://github.com/roozbehp/unicode-data/blob/67fa2d1bcb4dca1e8f296f1ffca59a3011718179/common.py#L27-L28 to sortscript_setby alias, but since codes are what shows up in the file, sorting by code seems reasonable enough.