Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTC-176-C35 Six compound tone diacritics #637

Merged

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Dec 20, 2023

[176-C35] Consensus: Provisionally assign U+1AD0..U+1AD5 for six compound tone diacritics, as given in L2/23-188. (Reference: Section 7 of L2/23-164)

[181-C60] Consensus: UTC accepts for encoding in Unicode Version 17.0 the following 297 Arabic, Bengali, Han, Kannada, Latin, Oriya, phonetic, Sharada, Tangut, Telugu, and symbol characters for which the code points have previously been provisionally assigned:

    Arabic (40 characters): 088F, FBC3..FBD2, FD90..FD91, FDC8..FDCE, 10EC5..10EC7, 10ED0..10ED8, 10EFA..10EFB
    Bengali (1 character): 09FF
    Han (5 characters): 16FF2..16FF6
    Kannada (1 character): 0CDC
    Latin (2 characters): A7D2, A7D4
    Oriya (2 characters): 0B53..0B54
    Phonetic (30 characters): 1ACF, 1AD0..1ADD, 1AE0..1AEB, A7CE..A7CF, A7F1
    Sharada (8 characters): 11B60..11B67
    Tangut (145 characters): 187F8..187FF, 18D09..18D1E, 18D80..18DF2
    Telugu (1 character): 0C5C
    Symbols (62 characters): 2B96, 1CCFA..1CCFC, 1CEBA..1CED0, 1CEE0..1CEF0, 1F777..1F77A, 1F8D0..1F8D8, 1FA54..1FA57, 1FBFA

@macchiati
Copy link
Member Author

macchiati commented Dec 20, 2023

Thanks, @eggrobin
What do you think about changing https://github.com/unicode-org/unicodetools/blob/main/docs/pipeline.md to be more explicit:

OLD
pipeline-* — Set label
NEW
pipeline-* — Set label to pipeline-provisionally-assigned or pipeline-<version>, depending on whether provisional or not.

@macchiati
Copy link
Member Author

Hmmm. The description does include a link to a UTC decision, namely https://www.unicode.org/L2/L2023/23157.htm#176-C35, but the Pipeline / UTC decision check fails.

@eggrobin
Copy link
Member

Hmmm. The description does include a link to a UTC decision, namely https://www.unicode.org/L2/L2023/23157.htm#176-C35, but the Pipeline / UTC decision check fails.

Yeah this regex is too strict, it expects the UTC- prefix: https://github.com/unicode-org/unicodetools/blob/main/py%2Fpipeline-workflow%2Fcheck-utc-decision.py#L10

@macchiati
Copy link
Member Author

Thanks!

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

unicodetools/data/ucd/dev/auxiliary/LineBreakTest.html Outdated Show resolved Hide resolved
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, looking at #588, these should also be Diacritic in PropList.txt
@eggrobin FYI

@eggrobin
Copy link
Member

Yes, I think this is a fairly clear-cut case of « diacritics are diacritics ».

(For, in contrast, a case where the Diacritic property is not clear-cut, see the very fun discussion in unicode-org/properties#233.)

@eggrobin eggrobin marked this pull request as ready for review November 11, 2024 15:48
@eggrobin
Copy link
Member

In January markus wrote:

actually, looking at #588, these should also be Diacritic in PropList.txt

(and then Mark sat on it). I’ll go ahead and do it.

markusicu
markusicu previously approved these changes Nov 13, 2024
@eggrobin eggrobin merged commit 7a3737c into unicode-org:main Nov 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants