Add likely project root as fallback cwd #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
wooorm
reviewed
Feb 3, 2022
| cwd = await packageDirectory({ | ||
| cwd: path.dirname(fileURLToPath(textDocument.uri)) | ||
| }) | ||
| } |
There was a problem hiding this comment.
I recommend switching between the 2 behaviors based on workspacesAsPaths.length > 0, instead of using one as a fallback for both o workspaces existing and a file not in a workspace.
Seems easier to reason about and debug
|
|
This is a draft because the tests are still failing (for good reasons). I just wanted to show it’s being worked on (although my spare time to work on this is a bit limited at the moment) |
This comment was marked as resolved.
This comment was marked as resolved.
ChristianMurphy
approved these changes
Feb 25, 2022
wooorm
approved these changes
Mar 2, 2022
wooorm
reviewed
Mar 2, 2022
|
The build is failing because of vfile/vfile-message@ebe7190 |
wooorm
reviewed
Mar 2, 2022
wooorm
approved these changes
Mar 2, 2022
5 tasks
wooorm
changed the title
This comment has been minimized.
This comment has been minimized.
wooorm
added
💪 phase/solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This uses the ancestor directory containng
package.jsonor.gitas the cwd forvfileandunified-engine.Closes #29