Skip to content

Commit

Permalink
192: Public Review delivery
Browse files Browse the repository at this point in the history
  • Loading branch information
keilw committed May 12, 2019
1 parent 831d6a1 commit 901457a
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 16 deletions.
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>tech.uom</groupId>
<artifactId>uom-parent</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.0-PRD</version>
</parent>
<licenses>
<license>
Expand All @@ -34,8 +34,8 @@
<!-- Build Settings -->
<!-- ======================================================= -->
<properties>
<jsr.version>2.0-SNAPSHOT</jsr.version>
<ri.version>2.0-SNAPSHOT</ri.version>
<jsr.version>2.0-PRD</jsr.version>
<ri.version>2.0-PRD</ri.version>
<jdkVersion>1.8</jdkVersion>
<project.build.javaVersion>${jdkVersion}</project.build.javaVersion>
<maven.compile.targetLevel>1.8</maven.compile.targetLevel>
Expand Down Expand Up @@ -121,7 +121,7 @@
<dependency>
<groupId>org.mutabilitydetector</groupId>
<artifactId>MutabilityDetector</artifactId>
<version>0.9.1</version>
<version>0.10.1</version>
</dependency>
<dependency>
<groupId>org.jboss.test-audit</groupId>
Expand Down
7 changes: 4 additions & 3 deletions src/main/java/tech/units/tck/TCKRunner.java
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
* Main class for executing the JSR 385 TCK.
*
* @author <a href="mailto:units@catmedia.us">Werner Keil</a>
* @version 1.5, February 21, 2019
* @version 1.6, May 12, 2019
* @since 1.0
*/
public class TCKRunner extends XmlSuite implements Tool, Versioned<String> {
Expand All @@ -91,7 +91,7 @@ public class TCKRunner extends XmlSuite implements Tool, Versioned<String> {
*
*/
//private static final long serialVersionUID = 3189431432291353154L;
private static final String TCK_VERSION = "2.0.0-SNAPSHOT";
private static final String TCK_VERSION = "2.0.0-PRD";
public static final String SPEC_ID = "JSR 385";
public static final String SPEC_VERSION = "2.0.0";
private final Profile profile;
Expand Down Expand Up @@ -137,7 +137,8 @@ public TCKRunner() {
*
* @param args Optional arguments to control TCK execution
*/
@Override
@SuppressWarnings("deprecation")
@Override
public int run(InputStream in, OutputStream out, OutputStream err, String... args) {
System.out.println("-- " + SPEC_ID + " TCK started --");
System.out.println("Profile: " + profile.getDescription());
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/tech/units/tck/util/ServiceConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
package tech.units.tck.util;

import javax.measure.Dimension;
import javax.measure.Prefix;
import javax.measure.Quantity;
import javax.measure.Unit;
import javax.measure.UnitConverter;
Expand All @@ -44,7 +45,7 @@
* interface and register it using the {@link ServiceLoader}.
*
* @author Werner Keil
* @version 1.1, Feb 21, 2019
* @version 1.2, May 12, 2019
* @since 1.0
*/
public interface ServiceConfiguration{
Expand All @@ -53,7 +54,7 @@ public interface ServiceConfiguration{
* Return a collection with all {@link Quantity} classes that are implemented. The list
* must not be empty and should contain <b>every</b> quantity class implemented.<p>
* This enables the TCK to check in addition to the basic implementation compliance, if
* according {@link ServiceProvider} is registered/available.
* according {@code ServiceProvider} is registered/available.
*
* @return a collection with all implemented amount classes, not null.
*/
Expand Down Expand Up @@ -93,16 +94,15 @@ public interface ServiceConfiguration{
* Return a collection with all supported {@link Quantity} types. The list
* must not return <tt>null</tt>, but could be empty in certain profiles.
*
* @return the list of quantity types to be checked, not <tt>null</tt>. It is allowed to return an empty list here, which will
*
* @return a collection with all implemented amount classes, not null.
* @return the list of quantity types to be checked, not <tt>null</tt>.
* It is allowed to return an empty list here, which will return a collection with all implemented amount classes, not null.
*/
@SuppressWarnings("rawtypes")
Collection<Class<? extends Quantity>> getSupportedQuantityTypes();

/**
* Returns a matching unit for the specified quantity type.
* This is a "helper method" to avoid direct references to {@link SystemOfUnits} or implementations in profiles without SPI.
* This is a "helper method" to avoid direct references to {@code SystemOfUnits} or implementations in profiles without SPI.
*
* @param <Q>
* the compile-time quantity type.
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/tech/units/tck/util/TestGroups.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
*
* @author <a href="mailto:werner@units.tech">Werner Keil</a>
* @author <a href="mailto:thodoris.bais@gmail.com">Thodoris Bais</a>
* @version 2.1, March 8, 2019
* @version 2.2, May 12, 2019
* @since 1.0
*/
public final class TestGroups {
Expand Down Expand Up @@ -85,15 +85,15 @@ public final class TestGroups {
/**
* Profiles used in the JSR 385 TCK.
*
* Some of the most common profiles (used by {@link TCKRunner}) are:
* Some of the most common profiles (used by {@link tech.units.tck.TCKRunner}) are:
* <ul>
* <li>{@link #MINIMAL} - used to include tests for the core elements of the API. These tests are <b>mandatory</b> for every implementation.</li>
* <li>{@link #FORMAT} - formatting tests used to include tests for elements in <tt>javax.measure.format</tt>.</li>
* <li>{@link #FULL} - All tests in the JSR 385 TCK.</li>
* </ul>
*
* @author Werner Keil
* @version 1.1
* @version 1.2
* @since 1.0
*/
public enum Profile implements DescriptionSupplier {
Expand Down

0 comments on commit 901457a

Please sign in to comment.