Fix exceptions on macOS

EXCEPTIONS GO BRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR it's 3am and i need sleep i spent way too long on this stupid bug but thats how code goes anyways good night
unofficial-rev-port · Jul 1, 2024 · 5712827 · 5712827
1 parent 79ab7e6
commit 5712827
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -73,7 +73,10 @@
       },
       "xcode_settings": {
           "CLANG_CXX_LANGUAGE_STANDARD": "c++20",
-          "OTHER_CPLUSPLUSFLAGS": ["-fexceptions"]
+          'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
+          'GCC_ENABLE_CPP_RTTI': 'YES',
+          "OTHER_CPLUSPLUSFLAGS": ["-fexceptions"],
+          # 'MACOSX_DEPLOYMENT_TARGET': '14.0',
       },
       "cflags_cc": ["-std=c++20", '-fexceptions'],
       "cflags": ["-std=c++20", '-fexceptions'],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@rev-robotics/can-bridge",
-    "version": "3.2.0",
+    "version": "3.2.6",
     "author": "REV Robotics",
     "description": "Access CAN Data from a USB device in Node.js",
     "license": "MIT",

diff --git a/scripts/download-CanBridge.mjs b/scripts/download-CanBridge.mjs
@@ -4,7 +4,7 @@ import axios from 'axios';
 import AdmZip from 'adm-zip';
 import { platform, arch } from 'os';
 
-const canBridgeTag = "v2.3.3";
+const canBridgeTag = "v2.3.6";
 const canBridgeReleaseAssetUrlPrefix = `https://github.com/unofficial-rev-port/CANBridge/releases/download/${canBridgeTag}`;
 
 const externalCompileTimeDepsPath = 'externalCompileTimeDeps';