Skip to content

Commit

Permalink
fix: Reimplement stopHeartbeats function to fix MSVC builds
Browse files Browse the repository at this point in the history
The stopHeartbeats function was removed in a previous commit, which caused MSVC builds to break. This commit re-adds the function to fix the build. The function will need to be reimplemented with the current codebase, as of right now this does nothing.
  • Loading branch information
garrettsummerfi3ld authored and qwertychouskie committed Jul 1, 2024
1 parent 8230825 commit c67f0e3
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/canWrapper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -768,3 +768,11 @@ void setSparkMaxHeartbeatData(const Napi::CallbackInfo& info) {
}
}

/**
* This function was removed from commit b0ca096624286b1e975eaaa816e38599933b7e84, which broke MSVC builds.
* It has been re-added here to fix the build.
*/
void stopHeartbeats(const Napi::CallbackInfo& info) {
//! TODO: Reimplement this function with current codebase
Napi::Env env = info.Env();
}

0 comments on commit c67f0e3

Please sign in to comment.