Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed xamlns clr-namespace: ... not working on uwp #66

Merged

Conversation

XiaotianNetlift
Copy link

Issue: #64

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Uwp fails with:

C:\code\Uno.WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.SampleApp.Shared\Pages\SampleController.xaml(343,26): 
XamlCompiler error WMC0001: Unknown type 'PaneStateTrigger' in XML namespace 
'clr-namespace:Microsoft.Toolkit.Uwp.SampleApp.Shared.Triggers;assembly=Microsoft.Toolkit.Uwp.SampleApp, Version=5.1.0.0, Culture=neutral, PublicKeyToken=null'

What is the new behavior?

Uwp build should pass.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@XiaotianNetlift
Copy link
Author

/azp run

@XiaotianNetlift XiaotianNetlift merged commit d32d053 into uno Oct 1, 2019
@XiaotianNetlift XiaotianNetlift deleted the dev/xygu/20190930/wmc0001-unknown-type-in-clr-namespace branch October 1, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants