Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Xcode version checks and manifests #177

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Oct 4, 2023

  • Fix the manifest (inverted version/name)
  • Update preview manifest with Xcode 15
  • Parse the correct string to retrive the Xcode version from Info.plist
  • On success show the installed Xcode version (and not the one specified in the manifest). That can be confusing if minimum is used in the manifest files

@spouliot spouliot requested a review from jeromelaban October 4, 2023 15:08
@nickrandolph nickrandolph merged commit 873057f into main Oct 9, 2023
30 checks passed
@nickrandolph nickrandolph deleted the fix-xcode-check branch October 9, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants