fix(androidsdk): only download arch independent or matching the host archives #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…archives This avoid downloading multiple files (one per arch) where the last one will be decompressed over the previous. E.g. ending up having `emulator` as a `arm64` binary on an `x86` Mac. Previous verbose logs showed: ``` ... – Downloading https://dl.google.com/android/repository/emulator-darwin_x64-10696886.zip ... – Downloading https://dl.google.com/android/repository/emulator-darwin_aarch64-10696886.zip ... ```
nickrandolph
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid downloading multiple files (one per arch) where the last one will be decompressed over the previous. E.g. ending up having
emulatoras aarm64binary on anx86Mac.Previous verbose logs showed: