Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the HR to be enabled on MVUX if app is built in DEBUG #1984

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Oct 27, 2023

Bugfix

Make the HR to be enabled on MVUX if app is built in DEBUG

What is the current behavior?

We assume that the first module initialized is the app head, but it might not be the case

What is the new behavior?

We check the module assembly name with the entry assembly name

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge October 30, 2023 13:40
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/3.0

@mergify
Copy link

mergify bot commented Oct 30, 2023

backport release/stable/3.0

✅ Backports have been created

@dr1rrb dr1rrb merged commit 17ce980 into main Oct 30, 2023
13 of 14 checks passed
@dr1rrb dr1rrb deleted the dev/dr/hr4mvux_2 branch October 30, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants