Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mvux): Fix selection not working properly #2219

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Mar 28, 2024

closes unoplatform/uno#15654

Bugfix

Fix selection not working properly

What is the current behavior?

  • ICollectionView.CurrentItem when selecting item right after the currently selected one, causing circular selection
  • Invalid coercing of the item index ranges
  • Invalid check to determine if an item is currently selected or not

What is the new behavior?

🙃

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge March 28, 2024 21:03
@dr1rrb dr1rrb force-pushed the dev/dr/mvuxSelectin branch 2 times, most recently from a080c15 to 68ed273 Compare April 1, 2024 14:53
@dr1rrb dr1rrb force-pushed the dev/dr/mvuxSelectin branch from 68ed273 to 04ac2a3 Compare April 1, 2024 17:11
@dr1rrb dr1rrb disabled auto-merge April 1, 2024 19:29
@dr1rrb dr1rrb merged commit e3d7b46 into main Apr 1, 2024
15 of 16 checks passed
@dr1rrb dr1rrb deleted the dev/dr/mvuxSelectin branch April 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant