Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #256
On the first interaction on #219, we thought that should be enough to look up the
ContentFilesProjectOutputGroupOutput
only, but we ignored the case where the user may have the a svg with the same name used as UnoImage, but in another location, something like:On the current version, the
SVG/car.svg
will not be packaged, because its name matches with theUnoImage
version. With this PR theSVG/car.svg
will be packaged, because it checks thefullpath
.But still, the same asset can't be used as UnoImage and Content, and this limitation is because we can't know if that was caused by some Uno task or the user want it, and when we have that it could cause unexpected behavior, see #218 for more context on it.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):