fix: ResourceExtensions throwing ArgumentException on windows #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agneszitte
reviewed
Jul 12, 2024
agneszitte
reviewed
Jul 12, 2024
Xiaoy312
force-pushed
the
dev/xygu/20240712/resource-ext--win-throws
branch
from
887814e to
8c29c36
Compare
Xiaoy312
force-pushed
the
dev/xygu/20240712/resource-ext--win-throws
branch
from
8c29c36 to
e0dfd7a
Compare
kazo0
approved these changes
Jul 12, 2024
|
@Mergifyio backport release/stable/6.1 |
✅ Backports have been created
|
agneszitte
reviewed
Jul 12, 2024
agneszitte
approved these changes
Jul 12, 2024
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
18 tasks
agneszitte
pushed a commit
that referenced
this pull request
Jul 15, 2024
#1190) (#1192) * fix: ResourceExtensions throwing ArgumentException on windows (cherry picked from commit e0dfd7a) * chore: reviewed changes Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com> (cherry picked from commit 17f2e6c) --------- Co-authored-by: xiaoy312 <xiaoyao312@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1187
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
ResourceExtensions.Resource no longer throw ArgumentException on windows when re-using the same resource-dictionary, such as when used in style setter.
PR Checklist
Please check if your PR fulfills the following requirements: