Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow a runtime test engine to start a nested instance #131

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 7, 2023

Feature

Allow a runtime-test runner to start a nested instance
This allow a runtime-test runner running on a CI to start a new instance for hot-reload tests

What is the current behavior?

The CI fails to start a second app as some environnement variables are already set

What is the new behavior?

We only update environnement variables, never try to add it!

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge November 7, 2023 14:28
@dr1rrb dr1rrb merged commit 752039b into main Nov 7, 2023
6 checks passed
@dr1rrb dr1rrb deleted the dev/dr/nested branch November 7, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants