Skip to content

Commit

Permalink
fix(sdk): Ensure IsPlatform defaults are always defined
Browse files Browse the repository at this point in the history
(cherry picked from commit 2f42371)
  • Loading branch information
ebariche authored and mergify[bot] committed Oct 17, 2024
1 parent 0e83d1d commit 0e32a7c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
2 changes: 2 additions & 0 deletions src/Uno.Sdk/Sdk/Sdk.props
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ Copyright (C) Uno Platform Inc. All rights reserved.
<DisableImplicitAspNetCoreAnalyzers Condition=" '$(DisableImplicitAspNetCoreAnalyzers)' == '' ">true</DisableImplicitAspNetCoreAnalyzers>
</PropertyGroup>

<Import Project="$(_UnoSdkTargetsDirectory)Uno.IsPlatform.Before.props" />

<Import Sdk="$(_DefaultMicrosoftNETSdk)" Project="Sdk.props" />

<PropertyGroup>
Expand Down
12 changes: 12 additions & 0 deletions src/Uno.Sdk/targets/Uno.IsPlatform.Before.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<Project>
<PropertyGroup>
<IsAndroid>false</IsAndroid>
<IsIOS>false</IsIOS>
<IsMacOS>false</IsMacOS>
<IsMacCatalyst>false</IsMacCatalyst>
<IsIOSOrCatalyst>false</IsIOSOrCatalyst>
<IsWinAppSdk>false</IsWinAppSdk>
<IsBrowserWasm>false</IsBrowserWasm>
<IsDesktop>false</IsDesktop>
</PropertyGroup>
</Project>
11 changes: 0 additions & 11 deletions src/Uno.Sdk/targets/Uno.IsPlatform.props
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
<Project>
<PropertyGroup>
<IsAndroid>false</IsAndroid>
<IsIOS>false</IsIOS>
<IsMacOS>false</IsMacOS>
<IsMacCatalyst>false</IsMacCatalyst>
<IsIOSOrCatalyst>false</IsIOSOrCatalyst>
<IsWinAppSdk>false</IsWinAppSdk>
<IsBrowserWasm>false</IsBrowserWasm>
<IsDesktop>false</IsDesktop>
</PropertyGroup>

<Choose>
<When Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
<PropertyGroup>
Expand Down

0 comments on commit 0e32a7c

Please sign in to comment.