Skip to content

Commit

Permalink
chore: Adjust workaround location
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromelaban committed Nov 16, 2024
1 parent 3b1e377 commit a31d62d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
14 changes: 14 additions & 0 deletions build/nuget/uno.winui.targets
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,18 @@
<Import Project="../uno.winui.runtime-replace.targets" Condition="'$(_UnoIsWinAppSDKDefined)'!='true'" />

<Import Project="../uno.winui.winappsdk.targets" Condition="'$(_UnoIsWinAppSDKDefined)'=='true'" />

<!-- HD workaround for https://github.com/dotnet/sdk/issues/1212, see HD#2924 -->
<Target Name="_RemoveHDAnalyzerRelease"
BeforeTargets="CoreCompile;XamlPreCompile"
Condition=" '$(Optimize)' == 'true' ">
<!---
Remove HD analyzers in release mode, as they cannot work in release mode.
-->
<ItemGroup>
<_HDAnalyzerToRemove Include="@(Analyzer)" Condition="'%(Analyzer.NuGetPackageId)'=='Uno.UI.HotDesign'" />
<Analyzer Remove="@(_HDAnalyzerToRemove)"/>
</ItemGroup>
</Target>

</Project>
13 changes: 0 additions & 13 deletions src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,4 @@
<ItemGroup>
<PackageReference Include="@(_UnoProjectSystemPackageReference)" Exclude="@(PackageReference)" />
</ItemGroup>

<!-- HD workaround for https://github.com/dotnet/sdk/issues/1212, see HD#2924 -->
<Target Name="_RemoveHDAnalyzerRelease"
BeforeTargets="CoreCompile;XamlPreCompile"
Condition=" '$(Optimize)' == 'true' ">
<!---
Remove HD analyzers in release mode, as they cannot work in release mode.
-->
<ItemGroup>
<_HDAnalyzerToRemove Include="@(Analyzer)" Condition="'%(Analyzer.NuGetPackageId)'=='Uno.UI.HotDesign'" />
<Analyzer Remove="@(_HDAnalyzerToRemove)"/>
</ItemGroup>
</Target>
</Project>

0 comments on commit a31d62d

Please sign in to comment.