Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gtk): Reduce visual artifacts for clipped paths #11663

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix(gtk): Reduce visual artifacts for clipped paths #11663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Uno.UI.Runtime.Skia.Gtk/GLRenderSurfaceBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,13 @@ internal abstract partial class GLRenderSurfaceBase : GLArea, IRenderSurface
/// <summary>
/// Include a guard band for the creation of the OpenGL surface to avoid
/// incorrect renders when the surface is exactly the size of the GLArea.
/// The current GLArea seems to have an issue with OpenGL rendering and
/// the first line rendering from the top. Adding one offsets the rendering
/// and prevents full area Skia surfaces to be blank, but causes issues in
/// rendering clipped shapes. Placing the GuardBand to one reduces but does
/// not remove the artifacts. See https://github.com/unoplatform/uno/issues/11139.
/// </summary>
private const int GuardBand = 32;
private const int GuardBand = 1;

private readonly DisplayInformation _displayInformation;
private FocusManager? _focusManager;
Expand Down