skia RichTextBlock paragraph implementation
#14878
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for the following reasons: - The IBlock interface differs from the IBlock implementation of the Block type: it has redundant properties and the absence of some that are present in the original IBlock implementation; - IBlock performs a different functionality and its name confuses with the name of the Block type implementation; - The ISegmentsElement type also has two new methods. They are needed because the RichTextBlock element, apart from the text, also has an InlineUIContainer type that is not related to the text in any way.
…llection type. This change is needed to give BlockCollection the ability to draw blocks.
…s: TextWrapping, TextAlignment, Foreground, LineStackingStrategy, LineHeight, MaxLines, HorizontalTextAlignment
github-actions
bot
added
area/skia ✏️
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14878/index.html |
…ping, TextAlignment, Foreground, LineStackingStrategy, LineHeight, MaxLines, HorizontalTextAlignment
github-actions
bot
added
the
platform/wasm 🌐
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14878/index.html |
|
Latest preview Preview.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #81
PR Status
Still under development.
The goal of PR
Implementation of Paragraph functionality for RichTextBlock.
Changelog
IBlock
interface has been replaced to ISegmentsElement.
This is necessary for the following reasons:
ISegmentsElement
implements the previous function of the IBlock interface and also has 2 additional methods: InvalidateElement and InvalidateSegments. These methods are analogous to the InvalidateInlines(bool updateText) method.
But since RichTextBlock contains a collection of Bloks, not Inlines, the name of this method has been generalized for both types.
Since the RichTextBlock type, in addition to text, also has an InlineUIContainer child element, the updateText parameter was removed, and the method was split into two methods.
ISegmentsElement type is needed in order not to write "RichTextBlock or TextBlock" condition every time.
SegmentsCollection
is only needed to generalize InlineCollection and BlockCollection.
The only change I added to it is to check if the element is a Paragraph for the GetPreorderTree method.
Still under development
Problems
Unfortunately, I did not understand how to add the default RichTextBlock style to the project.
I see it as follows:
But in the project I found only styles with x:Key specified.
Latest preview
Preview.mp4
Platforms