Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix java NRE handing touch events on detached view #1571

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): unoplatform/Uno.WindowsCommunityToolkit#59 (comment)

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Touching an element in an AutoSuggestBox may crash the application.

What is the new behavior?

The application does not crash.

This PR should be tested once unoplatform/Uno.UITest#19 is fixed.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

This fixes an issue with the AutosuggestBox, but should be tested one unoplatform/Uno.UITest#19 is fixed.
@jeromelaban jeromelaban changed the title Dev/jela/recycler touch [Android] Fix java NRE handing touch events on detached view Sep 20, 2019
Copy link
Contributor

@davidjohnoliver davidjohnoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI test would be nice

@jeromelaban
Copy link
Member Author

@davidjohnoliver This PR should be tested once unoplatform/Uno.UITest#19 is fixed.

@jeromelaban jeromelaban merged commit 8b9c1a7 into master Sep 23, 2019
@jeromelaban jeromelaban deleted the dev/jela/recycler-touch branch September 23, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants