feat: `ComboBox.IsEditable` #17792

MartinZikmund · 2024-08-01T13:23:20Z

GitHub Issue (If applicable): closes #9063

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2024-08-01T17:33:34Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-02T11:46:04Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-02T12:30:44Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-02T17:19:26Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.cs

unodevops · 2024-08-05T17:37:38Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-05T19:31:48Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-19T14:34:17Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-19T16:25:41Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-20T10:03:48Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-20T12:30:07Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-20T12:59:11Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-20T13:22:51Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-20T14:34:01Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-20T15:50:57Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-21T09:11:47Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-21T10:35:24Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-08-22T12:20:17Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

…nctionality

unodevops · 2024-10-05T06:34:25Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

unodevops · 2024-10-05T06:40:07Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17792/index.html

nventive-devops · 2024-10-05T09:03:50Z

The build 142363 found UI Test snapshots differences: android-28-net8: 25, android-28-net8-Snap: 37, ios: 42, ios-Snap: 46, skia-gtk-screenshots: 67, skia-linux-screenshots: 68, skia-windows-screenshots: 66, wasm: 233, wasm-automated-net9.0-UWP-Default-automated: 40, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 25 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- WebView_NavigateToAnchor_Initial
- WebView_NavigateToAnchor_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
- ComboBox_Dropdown_Background_ComboBox_open
- DatePicker_PickerFlyout_PlacementsbottomLeft_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- FocusManager_GetFocusedElement_ComboBox_Validation_FocusManager_-_GetFocusedElement_-_ComboBox_-_2_-_After_Selection
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
android-28-net8-Snap: 37 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ListView_ListViewVariableHeightButton_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewVariableHeightButton
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- TextBlock_SimpleText_MaxLines_Two_With_Wrap_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_Two_With_Wrap
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
- Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke
- WebView_WebView_Mailto_Uno_UI_Samples_Content_UITests_WebView_WebView_Mailto
- WebView_WebView_NavigateToUri_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToUri
- WebView_WebView2_JavascriptInvoke_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_JavascriptInvoke
- WebView_WebView2_NavigateToUri_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigateToUri
- Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
- Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
- MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
- TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_BrushColorChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_BrushColorChanging
ios: 42 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- Check_CornerRadius_Border_No_CornerRadius
- Check_CornerRadius_Border_CornerRadius=5
- Check_CornerRadius_Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle
- ScrollViewer_WhenAsync_RunIdleAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesMode
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ComboBoxTests_ToggleDisabled_ComboBox_Enabled
- ScrollViewer_Content_Margin_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Content_Margin
- ScrollViewer_Removed_And_Added_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_Remove
- When_CustomContentAndLongTitle_TitleShouldNotOverlapBarButtons_OnNavigateBack_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_Frame
- When_CustomContent_CommandBarTitleShouldBeVisible_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_CustomContent_CommandBar_Frame
- When_Target_Is_Set_After_Start_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty
- XamlCommandBar_Automated_AfterShuffle
- XamlCommandBar_Automated_Initial
- ComboBoxTests_ToggleDisabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ToggleDisabled
- ScrollViewer_Removed_And_Added_Initial
- ScrollViewer_Removed_And_Added_Restored
- ScrollViewer_Clipping_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Clipping
- ScrollViewer_Removed_And_Added_Gone
- ScrollViewer_Removed_And_Added_Initial-Scrolled
- XamlCommandBar_Automated_AfterClickMe
ios-Snap: 46 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
- Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
- Image_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_Containers
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Brushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
- Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
- Clipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- NavigationView_MUXControlsTestApp_NavigationViewSelectedItemEdgeCasePage_MUXControlsTestApp_NavigationViewSelectedItemEdgeCasePage
- NavigationView_MUXControlsTestApp_NavigationViewStretchPage_MUXControlsTestApp_NavigationViewStretchPage
- TextBlock_Attributed_text_FontSize_Changing_Uno_UI_Samples_Content_UITests_TextBlockControl_Attributed_text_FontSize_Changing
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
skia-gtk-screenshots: 67 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- Examples.png
- ImageBrushAlignmentXY2.png
- ImageBrushStretch.png
- SelectorBarSamplePage.png-dark
- SelectorBarSamplePage.png
- UIElement_MeasureDirtyPath.png-dark
- UIElement_MeasureDirtyPath.png
- ImageBrush_UniformToFill.png
- ClipboardTests.png-dark
- ImageBrushAlignmentXY.png
- ImageBrushAlignmentXY2.png-dark
- ToggleButton_IsEnabled_Automated.png-dark
- ToggleButton_IsEnabled_Automated.png
- ClipboardTests.png
- DisplayInformation.png-dark
- DisplayInformation.png
skia-linux-screenshots: 68 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- ExpanderColorValidationPage.png-dark
- ExpanderColorValidationPage.png
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- Buttons.png-dark
- DragDrop_TestPage.png-dark
- DragDrop_TestPage.png
- CalendarView_Theming.png-dark
- Examples.png
- ImageIconPage.png-dark
- ImageIconPage.png
- ImageInStackPanel.png-dark
- ImageInStackPanel.png
- Image_Stretch_None.png-dark
- Image_Stretch_None.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- ContentPresenter_NativeEmbedding.png-dark
skia-windows-screenshots: 66 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- DisplayInformation.png-dark
- DisplayInformation.png
- ClipboardTests.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- ImageBrushAlignmentXY2.png-dark
- ImageBrushAlignmentXY2.png
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- Ellipse.png-dark
- Ellipse.png
- ButtonClippingTestsControl.png-dark
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- ClipboardTests.png-dark
- BorderImageBrush.png-dark
- BorderImageBrush.png
- Buttons.png
wasm: 233 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
- MUXControlsTestApp.RadialGradientBrushPage
- SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListView_Templates
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Padding_Unconstrained
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_SelectedItem
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathIcon
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- UITests.Shared.Windows_UI_Xaml_Controls.GridTestsControl.Grid_Spacing_Adjustable
- UITests.Shared.Windows_UI_Xaml_Controls.GridTestsControl.Grid_with_OutOfRange_Cells
- UITests.Windows_UI_Xaml_Controls.ImageTests.ImageWithLateSourceUniformToFill
- UITests.Windows_UI_Xaml_Controls.SwipeControlTests.SwipeControl_ListView_ItemClick
- UITests.Windows_UI_Xaml_Media_Animation.ColorAnimation_Background
- GenericApp.Views.Content.UITests.ContentControlTestsControl.ContentControl_UnsetContent
- initial_state
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewChangeViewArbitrary
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewContainerFromItem
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewResizable
- UITests.Shared.Windows_UI_Xaml_Controls.Button.Button_Events
- UITests.Shared.Windows_UI_Xaml_Controls.Button.Overlapped_Buttons
- UITests.Shared.Windows_UI_Xaml_Controls.Button.RadioButton_Combined_Style
wasm-automated-net9.0-UWP-Default-automated: 40 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_Dropdown_Background_ComboBox_open
- FocusManager_GetFocusedElement_TextBoxSingleLine_Validation_FocusManager_-_GetFocusedElement_-_TextBoxSingleLine_-_2_-_After_Selection
- FocusManager_GetFocusedElement_ComboBox_Validation_FocusManager_-_GetFocusedElement_-_ComboBox_-_2_-_After_Selection
- Default_StrokeThickness_MyPath
- Default_StrokeThickness_MyPath_0_StrokeThickness
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Default_StrokeThickness_MyEllipse
- Default_StrokeThickness_MyPolyline
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- Default_StrokeThickness_MyRect
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

MartinZikmund changed the title ~~chore: Start IsEditable support for ComboBox~~ [WIP] feat: ComboBox.IsEditable Aug 1, 2024

MartinZikmund linked an issue Aug 2, 2024 that may be closed by this pull request

ComboBox.IsEditable is not implemented #9063

Closed

MartinZikmund force-pushed the dev/mazi/iseditable branch from a6b5d7c to 531dd2a Compare August 2, 2024 11:51

MartinZikmund force-pushed the dev/mazi/iseditable branch from cd4c24c to baaaf97 Compare August 2, 2024 15:13

MartinZikmund force-pushed the dev/mazi/iseditable branch from baaaf97 to d31fc95 Compare August 5, 2024 15:48

carldebilly reviewed Aug 5, 2024

View reviewed changes

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.cs Outdated Show resolved Hide resolved

MartinZikmund force-pushed the dev/mazi/iseditable branch from 7a9c010 to 946f837 Compare August 19, 2024 13:28

MartinZikmund force-pushed the dev/mazi/iseditable branch from f966eb6 to 4ab066c Compare August 20, 2024 12:26

MartinZikmund force-pushed the dev/mazi/iseditable branch from 8bfb1c2 to 4461d40 Compare August 21, 2024 08:34

MartinZikmund force-pushed the dev/mazi/iseditable branch from a753f2b to 2ba34d3 Compare August 22, 2024 11:25

github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Aug 22, 2024

MartinZikmund force-pushed the dev/mazi/iseditable branch from 2ba34d3 to f9624a7 Compare August 22, 2024 11:41

MartinZikmund added 24 commits October 5, 2024 08:04

chore: Properly track last input device type on Android

6372d01

chore: Adjust usings

cac4363

chore: Disable tab behavior test on UWP

af43c00

chore: Set light dismiss flag earlier

e07f47c

chore: Adjust usings

d58e2fe

chore: Adjust invalid active visual state test

17ff273

chore: Disable TextBox input tests temporarily

9d7fc3a

chore: Disable various addiitonal tests due to missing InputHelper fu…

ebc13e7

…nctionality

chore: Test not passing due to lifecycle

6aef827

chore: Adjust tests for mobile targets

27b8448

fix: Adjust TreeHelper to correctly handle native elements

06e9137

chore: Disable test on Android due to focus behavior

c7be5ea

chore: Adjust for existing port

834003a

chore: Adjust furhter tests

07fc9a5

chore: Cleanup

7fdef45

fix: GetCharacterIndexAtPoint throws if layout manager is null

97d9c7d

chore: Adjust ComboBox to handle iOS Picker

129a34e

chore: Ensure UI-bound input helpers run on UI thread

502477c

chore: Disable Knob_Translation in CI for Android

a9c5cfc

chore: Mark test flaky on iOS (#9080)

35126b6

chore: Try disabling test

04920af

fix: Ensure each test ends with non-keyboard input device

c60e172

chore: Re-enable test

5c80491

chore: Set the initial input device type to mouse in between tests

366aeef

MartinZikmund force-pushed the dev/mazi/iseditable branch from 58b0ae6 to 366aeef Compare October 5, 2024 06:04

MartinZikmund merged commit 97b0020 into master Oct 5, 2024
110 checks passed

MartinZikmund deleted the dev/mazi/iseditable branch October 5, 2024 09:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `ComboBox.IsEditable` #17792

feat: `ComboBox.IsEditable` #17792

MartinZikmund commented Aug 1, 2024 •

edited

Loading

unodevops commented Aug 1, 2024

unodevops commented Aug 2, 2024

unodevops commented Aug 2, 2024

unodevops commented Aug 2, 2024

unodevops commented Aug 5, 2024

unodevops commented Aug 5, 2024

unodevops commented Aug 19, 2024

unodevops commented Aug 19, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 21, 2024

unodevops commented Aug 21, 2024

unodevops commented Aug 22, 2024

unodevops commented Oct 5, 2024

unodevops commented Oct 5, 2024

nventive-devops commented Oct 5, 2024

feat: ComboBox.IsEditable #17792

feat: ComboBox.IsEditable #17792

Conversation

MartinZikmund commented Aug 1, 2024 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

unodevops commented Aug 1, 2024

unodevops commented Aug 2, 2024

unodevops commented Aug 2, 2024

unodevops commented Aug 2, 2024

unodevops commented Aug 5, 2024

unodevops commented Aug 5, 2024

unodevops commented Aug 19, 2024

unodevops commented Aug 19, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 20, 2024

unodevops commented Aug 21, 2024

unodevops commented Aug 21, 2024

unodevops commented Aug 22, 2024

unodevops commented Oct 5, 2024

unodevops commented Oct 5, 2024

nventive-devops commented Oct 5, 2024

feat: `ComboBox.IsEditable` #17792

feat: `ComboBox.IsEditable` #17792

MartinZikmund commented Aug 1, 2024 •

edited

Loading