Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DP system simplifications #17971

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 19, 2024

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

OverrideMetadata is a WPF thingy and not present in WinUI. We shouldn't need it. It's currently used only to override default values, which WinUI does in a different way.

For Button, [Horizontal|Vertical]ContentAlignmentProperty is already Center unless UseLegacyContentAlignment is set to true (no one should be using this legacy flag actually)

For ProgressBar, Maximum correct value is actually 1

For ScrollViewer, [Horizontal|Vertical]ContentAlignmentProperty is actually Center in WinUI so our override is wrong

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17971/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17971/index.html

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Aug 19, 2024
@Youssef1313 Youssef1313 marked this pull request as draft August 19, 2024 14:10
@Youssef1313 Youssef1313 marked this pull request as ready for review August 19, 2024 14:22
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17971/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17971/index.html

@Youssef1313 Youssef1313 enabled auto-merge August 19, 2024 19:05
@Youssef1313 Youssef1313 disabled auto-merge August 19, 2024 19:05
@Youssef1313 Youssef1313 merged commit 3295c52 into unoplatform:master Aug 19, 2024
102 checks passed
@Youssef1313 Youssef1313 deleted the getdefaultvalue branch August 19, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants