Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid XBF changes to not break WinAppSDK build #17993

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313
Copy link
Member Author

cc @kazo0
We'll also need to test whether this fixes the issue, and also make sure it doesn't regress HR indicator.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17993/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17993/index.html

@Youssef1313 Youssef1313 changed the title DRAFT fix: Avoid XBF changes to not break WinAppSDK build Aug 22, 2024
@Youssef1313
Copy link
Member Author

Locally tested and working fine.

@kazo0 Can you do a second quick pass so we can merge after?

@Youssef1313 Youssef1313 marked this pull request as ready for review August 22, 2024 13:48
@carldebilly carldebilly merged commit ce18405 into unoplatform:master Aug 22, 2024
97 of 99 checks passed
@Youssef1313 Youssef1313 deleted the fix-hr branch August 22, 2024 13:54
@Youssef1313
Copy link
Member Author

@Mergifyio backport release/stable/5.3

Copy link
Contributor

mergify bot commented Aug 22, 2024

backport release/stable/5.3

✅ Backports have been created

carldebilly added a commit that referenced this pull request Aug 22, 2024
…5.3/pr-17993

fix: Avoid XBF changes to not break WinAppSDK build (backport #17993)
@dr1rrb
Copy link
Member

dr1rrb commented Aug 26, 2024

😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants