chore: Remove ContentTemplateSelector references from Styles
#18125
+0
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morning4coffe-dev
added
the
do-not-merge/work-in-progress
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18125/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18125/index.html |
|
The build 138797 found UI Test snapshots differences: Details
|
|
Waiting on #17645 |
|
CC @MartinZikmund, @Xiaoy312 Can I continue with this change? |
|
@morning4coffe-dev I think it should now be ok to continue! |
morning4coffe-dev
requested review from
Xiaoy312,
MartinZikmund and
jeromelaban
morning4coffe-dev
removed
the
do-not-merge/work-in-progress
Xiaoy312
reviewed
Nov 7, 2024
| @@ -204,8 +202,6 @@ | |||
| Content="{TemplateBinding Content}" | |||
| ContentTransitions="{TemplateBinding ContentTransitions}" | |||
| ContentTemplate="{TemplateBinding ContentTemplate}" | |||
| ContentTemplateSelector="{TemplateBinding ContentTemplateSelector}" | |||
| CornerRadius="{TemplateBinding CornerRadius}" | |||
There was a problem hiding this comment.
i can see why they are getting removed
but could you also go through the screenshot comparison tests and make sure that we didnt break anything?
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18125/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18125/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #18103 closes?
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.