Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glcanvaselement skia macos #18385

Merged

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): #9405, follows from #18216

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Oct 3, 2024
@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from 8a01672 to eb2f9fa Compare October 4, 2024 11:31
@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform kind/documentation labels Oct 4, 2024
@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from eb2f9fa to cc62d18 Compare October 4, 2024 12:57
@ramezgerges
Copy link
Contributor Author

this branch is currently on top of #18216. Rebase on top of master after merging #18216

@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from cc62d18 to c6a494f Compare October 4, 2024 16:19
@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from 29084f5 to a7c6271 Compare October 7, 2024 13:40
@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia and removed platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform labels Oct 7, 2024
@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from 618bd6b to cca07f1 Compare October 7, 2024 17:34
@ramezgerges ramezgerges marked this pull request as ready for review October 7, 2024 17:34
@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from 0bc3168 to 71350c9 Compare October 7, 2024 18:37
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18385/index.html

@ramezgerges ramezgerges force-pushed the glcanvaselement_skia_macos branch from ff7c4c7 to 9f23ac3 Compare October 7, 2024 20:34
@ramezgerges ramezgerges enabled auto-merge October 7, 2024 21:11
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18385/index.html

@jeromelaban
Copy link
Member

@ramezgerges, using the generated samples app:
image

fail: Uno.Graphics.INativeOpenGLWrapper[0]
      INativeOpenGLWrapper creation failed.
      System.DllNotFoundException: Unable to load shared library 'libEGL.dylib' or one of its dependencies. In order to help diagnose loading problems, consider setting the DYLD_PRINT_LIBRARIES environment variable:
      dlopen(/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/runtimes/osx/native/libEGL.dylib, 0x0001): tried: '/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/runtimes/osx/native/libEGL.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/runtimes/osx/native/libEGL.dylib' (no such file), '/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/runtimes/osx/native/libEGL.dylib' (no such file)
      dlopen(/usr/local/share/dotnet/shared/Microsoft.NETCore.App/8.0.8/libEGL.dylib, 0x0001): tried: '/usr/local/share/dotnet/shared/Microsoft.NETCore.App/8.0.8/libEGL.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/share/dotnet/shared/Microsoft.NETCore.App/8.0.8/libEGL.dylib' (no such file), '/usr/local/share/dotnet/shared/Microsoft.NETCore.App/8.0.8/libEGL.dylib' (no such file)
      dlopen(/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/libEGL.dylib, 0x0001): tried: '/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/libEGL.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/libEGL.dylib' (no such file), '/Users/jay/142565-artifacts/skia-generic-samples-app-WinUI/libEGL.dylib' (no such file)
      dlopen(libEGL.dylib, 0x0001): tried: 'libEGL.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OSlibEGL.dylib' (no such file), '/usr/lib/libEGL.dylib' (no such file, not in dyld cache), 'libEGL.dylib' (no such file), '/usr/local/lib/libEGL.dylib' (no such file), '/usr/lib/libEGL.dylib' (no such file, not in dyld cache)

@ramezgerges
Copy link
Contributor Author

@jeromelaban My bad. The script that builds ANGLE only ran when building on MacOS. Now that we're not building anything (just fetching from github), it should run when building anywhere.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18385/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18385/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18385/index.html

@ramezgerges ramezgerges merged commit ed92c1e into unoplatform:master Oct 8, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia kind/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants