Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Tabview Selection when Bindings items #18492

Merged
merged 9 commits into from
Oct 22, 2024
Merged

fix(ios): Tabview Selection when Bindings items #18492

merged 9 commits into from
Oct 22, 2024
+121 −18

Conversation

ajpinedam
Copy link
Contributor

GitHub Issue (If applicable): closes https://github.com/unoplatform/ziidms-private/issues/23

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Using TabView with bound items and changing the SelectedItem is causing the TabView Tabs to display incorrectly.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Oct 16, 2024
@github-actions github-actions bot added the platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform label Oct 16, 2024
@Xiaoy312 Xiaoy312 force-pushed the ajpm/fix.ios.tabview.with.bindings branch from 6384f45 to c4ff756 Compare October 16, 2024 21:46
@github-actions github-actions bot removed the platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform label Oct 16, 2024
@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Oct 16, 2024 •
edited by ajpinedam
Loading

todo @ajpinedam:

  • sanity-check for android
  • create an issue for reminder to restore the bring-into-view that we disabled for out-of-screen items (ios and possibly droid)

@ajpinedam ajpinedam force-pushed the ajpm/fix.ios.tabview.with.bindings branch from c4ff756 to 384eee0 Compare October 17, 2024 03:56
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@ajpinedam
Copy link
Contributor Author

todo @ajpinedam:

* [x]  sanity-check for android

* [x]  create an issue for reminder to restore the bring-into-view that we disabled for out-of-screen items (ios and _possibly droid_)

Validated Android and the issue fixed here is absent in Android. But the BringIntoView is not working correctly there. TabViewItem is selected but not made visible.

Follow-up ticket: #18499

@ajpinedam ajpinedam marked this pull request as ready for review October 17, 2024 05:06
@ajpinedam ajpinedam mentioned this pull request Oct 17, 2024
Closed
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@ajpinedam ajpinedam force-pushed the ajpm/fix.ios.tabview.with.bindings branch from 1394158 to 39081b6 Compare October 17, 2024 13:20
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/build Categorizes an issue or PR as relevant to build infrastructure area/automation Categorizes an issue or PR as relevant to project automation kind/documentation area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk labels Oct 20, 2024
@ajpinedam ajpinedam force-pushed the ajpm/fix.ios.tabview.with.bindings branch from 5007215 to 29e35df Compare October 20, 2024 15:52
@github-actions github-actions bot removed area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/build Categorizes an issue or PR as relevant to build infrastructure area/automation Categorizes an issue or PR as relevant to project automation kind/documentation area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk labels Oct 20, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@ajpinedam ajpinedam linked an issue Oct 22, 2024 that may be closed by this pull request
[iOS] TabView tabs seem to not render #18068
Closed
@ajpinedam ajpinedam mentioned this pull request Oct 22, 2024
Open
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

@jeromelaban jeromelaban merged commit 8545b92 into unoplatform:master Oct 22, 2024
108 checks passed
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024 •
edited
Loading

backport release/stable/5.5

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 22, 2024
Merged
6 tasks
jeromelaban added a commit that referenced this pull request Oct 22, 2024
@jeromelaban
Merge pull request #18542 from unoplatform/mergify/bp/release/stable/…
5384cc4 
…5.5/pr-18492

fix(ios): Tabview Selection when Bindings items (backport #18492)
@ajpinedam ajpinedam deleted the ajpm/fix.ios.tabview.with.bindings branch October 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees

@ajpinedam ajpinedam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] TabView tabs seem to not render
5 participants
@ajpinedam @Xiaoy312 @unodevops @jeromelaban @MartinZikmund