fix(iOS): textbox selection clear button #18522
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/ios 🍎
ajpinedam
commented
Oct 21, 2024
| @@ -51,7 +51,10 @@ protected override Size MeasureOverride(Size availableSize) | |||
|
|
|||
| for (int i = 0; i < count; i++) | |||
| { | |||
| var view = Children[i]; | |||
| if (Children[i] is not { } view) | |||
There was a problem hiding this comment.
I see situations where one of the children is null, causing the app to behave wrongly. More specifically when tapping inside an iOS TextBox.
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18522/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18522/index.html |
Youssef1313
reviewed
Oct 21, 2024
| @@ -26,6 +26,11 @@ public IEnumerable<View> GetChildren() | |||
|
|
|||
| protected Size MeasureChildOverride(View view, Size slotSize) | |||
| { | |||
| if (view is null) | |||
| { | |||
There was a problem hiding this comment.
@MartinZikmund Looks like a proper fix may be needed :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes unoplatform/Uno.Themes#1458
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the iOS selection in the TextBox occurs, an exception is sometimes raised, causing the clear button textbox not to show.
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):