Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skia): (partially) implement ShapeVisual.ViewBox and fix ShapeVisual clipping #18561

Merged
merged 13 commits into from
Nov 8, 2024

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #18528

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ramezgerges ramezgerges requested a review from dr1rrb October 23, 2024 20:18
@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Oct 23, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18561/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18561/index.html

@ramezgerges ramezgerges enabled auto-merge November 4, 2024 10:49
@jeromelaban
Copy link
Member

@MartinZikmund MartinZikmund removed their assignment Nov 6, 2024
@jeromelaban jeromelaban marked this pull request as draft November 6, 2024 19:31
auto-merge was automatically disabled November 6, 2024 19:31

Pull request was converted to draft

@ramezgerges
Copy link
Contributor Author

@jeromelaban It's just the flakiness of screenshot tests with images. I've checked locally and it's working fine.

@ramezgerges ramezgerges marked this pull request as ready for review November 7, 2024 13:53
@jeromelaban jeromelaban merged commit d3fcbf9 into unoplatform:master Nov 8, 2024
108 checks passed
@ramezgerges ramezgerges deleted the composition_viewbox branch November 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop/Desktop WSL] Events Not Triggered When Using Image
5 participants