Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't include non-existing pwa manifest #18652

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

jeromelaban
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Fixes the ability to disable the PWA manifest

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk label Nov 1, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18652/index.html

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.5

Copy link
Contributor

mergify bot commented Nov 1, 2024

backport release/stable/5.5

✅ Backports have been created

Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeromelaban jeromelaban merged commit 9ccb7bf into master Nov 4, 2024
105 of 108 checks passed
@jeromelaban jeromelaban deleted the dev/jela/optional-pwa branch November 4, 2024 14:06
jeromelaban added a commit that referenced this pull request Nov 4, 2024
…5.5/pr-18652

fix: Don't include non-existing pwa manifest (backport #18652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants