Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the way pings are done to the remote control / dev server #18687

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

carldebilly
Copy link
Member

Bugfix

What is the current behavior?

The first ping to dev server was done 30 seconds after the connection. Since some checks are only done during ping response, it was causing potential unwanted delay.

What is the new behavior?

An initial ping is sent immediately after the connection has been established.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@carldebilly carldebilly requested a review from dr1rrb November 4, 2024 19:23
@carldebilly carldebilly changed the title Improved the way pings are done to the remote control server Improved the way pings are done to the remote control / dev server Nov 4, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18687/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18687/index.html

@carldebilly carldebilly marked this pull request as ready for review November 5, 2024 16:06
@jeromelaban jeromelaban merged commit f3bdeb8 into master Nov 5, 2024
91 of 107 checks passed
@jeromelaban jeromelaban deleted the dev/cdb/remote-control-ping-delay branch November 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants