fix: Use temp file for AddIn discovery instead of output parsing #18733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void encoding issues
|
@Mergifyio backport release/stable/5.5 |
jeromelaban
approved these changes
Nov 7, 2024
✅ Backports have been created
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18733/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18733/index.html |
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Nov 8, 2024
…5.5/pr-18733 fix: Use temp file for AddIn discovery instead of output parsing (backport #18733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18732
Bugfix
Use temp file for AddIn discovery instead of output parsing
What is the current behavior?
We rely on some XML like tags in build output to discover add-ins
What is the new behavior?
We now dump values in a temp file that we read at the end of the build. This makes sure we are not impacted by encoding issues in output.
PR Checklist
Screenshots Compare Test Runresults.